Keep .sum files for modules #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @martin-sucha! Do you mind repushing. Somehow Github Actions did not run OR status was removed due to age of this PR? (: Let's get this merged! |
martin-sucha
force-pushed
the
ms/sum-files
branch
from
479d590 to
418731d
Compare
|
Hi @bwplotka! I have squashed the commits here and pushed again. GitHub now says that a maintainer needs to approve the workflow. Note that we have seen |
.sum files are used for verifying the downloaded modules, so are useful for security. Don't ignore them. Bingo deletes all *.tmp.* files. We need to rename not just .mod file but .sum file as well. We also need to copy the sum file to temporary file. Existing users don't have .sum files in their .bingo directory, so we ignore file not found errors for .sum files. Fixes bwplotka#15
martin-sucha
force-pushed
the
ms/sum-files
branch
from
418731d to
d5a68de
Compare
|
@bwplotka I have fixed the formatting, so linters should pass now. Please approve the workflow again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.sum files are used for verifying the downloaded modules,
so are useful for security. Don't ignore them.
Fixes #15