Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support #26

Open
bwplotka opened this issue Jun 5, 2020 · 4 comments
Open

Add windows support #26

bwplotka opened this issue Jun 5, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bwplotka
Copy link
Owner

bwplotka commented Jun 5, 2020

AC:

  • Add Github Action windows runner to test against windows
  • Decide how Makefile / variables.env should work on Windows platform, and adjust for windows (e.g. should we support PowerShell, any other requirements?)
@bwplotka bwplotka added enhancement New feature or request help wanted Extra attention is needed labels Jun 5, 2020
@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Jun 7, 2021

minimally we need to quote more. ex this:

--- a/.bingo/Variables.mk
+++ b/.bingo/Variables.mk
@@ -21,23 +21,23 @@ GOIMPORTS := $(GOBIN)/goimports-v0.1.2
 $(GOIMPORTS): $(BINGO_DIR)/goimports.mod
        @# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
        @echo "(re)installing $(GOBIN)/goimports-v0.1.2"
-       @cd $(BINGO_DIR) && $(GO) build -mod=mod -modfile=goimports.mod -o=$(GOBIN)/goimports-v0.1.2 "golang.org/x/tools/cmd/goimports"
+       @cd "$(BINGO_DIR)" && "$(GO)" build -mod=mod -modfile=goimports.mod -o="$(GOBIN)/goimports-v0.1.2" "golang.org/x/tools/cmd/goimports"

codefromthecrypt pushed a commit to tetratelabs/func-e that referenced this issue Jun 7, 2021
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt pushed a commit to tetratelabs/func-e that referenced this issue Jun 7, 2021
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt pushed a commit to tetratelabs/func-e that referenced this issue Jun 7, 2021
Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Contributor

I think spaces just won't work. there are a bunch of reasons why. windows would only work if you can use non-spaces for both go and the checked out project

@codefromthecrypt
Copy link
Contributor

one main issue is that go env GOPATH comes out like `c:...'

The result is this is ambiguous and fails

GOBIN  ?= $(firstword $(subst :, ,${GOPATH}))/bin

@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Jun 7, 2021

This seems to work around things well enough in git bash assuming you have go installed in a non-spaced directory such as you'd get using https://github.com/travis-ci/gimme

--- a/.bingo/Variables.mk
+++ b/.bingo/Variables.mk
@@ -2,7 +2,9 @@
 # All tools are designed to be build inside $GOBIN.
 BINGO_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
 GOPATH ?= $(shell go env GOPATH)
-GOBIN  ?= $(firstword $(subst :, ,${GOPATH}))/bin
+# This handles translation for Windows, but only in cygwin or similar environments
+PATHSEP := $(if $(COMSPEC),;,:)
+GOBIN  ?= $(firstword $(subst $(PATHSEP), ,$(subst \,/,${GOPATH})))/bin
 GO     ?= $(shell which go)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants