feat( add OAuth2 support ) #1533
Open
+832
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved oauth2.go and oauth2_test.go to applications.go and
applications_test.go
added basic OAuth2 endpoints to endpoints.go
added util functions for creating 'Basic' token from client id
and secret to util.go
added util functions for prefixing 'Bearer' and 'Bot' tokens to
util.go
added methods to check token type on Sessions in structs.go
added wrong token type errors to restapi.go
changed RequestWithBucketID to use x-form-urlencoded encoding
when given a url.Values data object to deal with discord's
pendantic OAuth2 spec adherence
created oauth2.go with basic OAuth2 types
added ability to preform OAuth2 operation with a Session
created from a 'Basic' token using client id and secret
added ability to get OAuth2 authorization information for
Session's created with 'Bearer' and 'Bot' tokens
added godoc comments for above
created a OAuth2 demo server in examples
|
what is the likelyhood of this or something similar in the next version? |
pavelapk
reviewed
Aug 25, 2024
| if err = s.checkBasicSession(); err != nil { return } | ||
| body, err := s.RequestWithBucketID( "POST", EndpointOAuth2Token, data, EndpointOAuth2Token, options... ) | ||
| if err == nil { | ||
| err = unmarshal( body, &st ) |
There was a problem hiding this comment.
unhandled error, I caught a panic here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Discord's OAuth2 token api.
closes #1534