Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix RTL scrolling issues in some browsers #162

Closed
wants to merge 6 commits into from

Conversation

davidgarsan
Copy link
Contributor

@davidgarsan davidgarsan commented Mar 6, 2019

Attempt to fix some RTL scrolling issues in some browsers due to inconsistent RTL support.
Tested in Chrome, Firefox and Safari latest versions.
The fix is ugly as hell but needs to tackle at least tree different cases:

  • Non standard Chrome support for RTL overflow metrics.
  • Standard support from Firefox.
  • Buggy behaviour on Safari bouncing when the scroll reaches the right limit in RTL layout.

Pending tasks:

  • Testing in Edge.
  • Fix scrollToItem and scrollTo methods to work with RTL direction.
  • Apply similar fix for Grid component.

@bvaughn bvaughn force-pushed the master branch 2 times, most recently from 3153343 to c14bce6 Compare March 8, 2019 04:00
@bvaughn
Copy link
Owner

bvaughn commented May 27, 2019

Thanks for this PR!

I think I've found an approach that handles the underlying offset differences and also fixes the imperative scroll-to methods though in PR #251

Going to close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants