Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grid ssr with maxElementSize util #970

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Fix Grid ssr with maxElementSize util #970

merged 2 commits into from
Jan 16, 2018

Conversation

TrySound
Copy link
Contributor

Ref #936

Copy link
Owner

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks buddy!

Will you handle the NPM release as well?

@TrySound
Copy link
Contributor Author

Sure.

@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #970 into master will increase coverage by 0.19%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage      90%   90.19%   +0.19%     
==========================================
  Files          59       59              
  Lines        1670     1672       +2     
==========================================
+ Hits         1503     1508       +5     
+ Misses        167      164       -3
Impacted Files Coverage Δ
source/Grid/utils/maxElementSize.js 88.88% <75%> (+3.17%) ⬆️
source/WindowScroller/utils/dimensions.js 100% <0%> (+5%) ⬆️
source/utils/animationFrame.js 72.72% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d842fb6...d133dd7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants