-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: React 19 fixes for Table related components #1855
base: master
Are you sure you want to change the base?
fix: React 19 fixes for Table related components #1855
Conversation
React 19.0.0 is stable and would be nice to support it: |
Please! Really need this |
For the love of god and maybe an early xmas gift can someone just come in and hit the merge button? |
@bvaughn any chance this can be merged? |
The merge is blocked. Please OKAY this for merge. The world needs this fix yesterday! |
Thanks for contributing to react-virtualized!
Before submitting a pull request, please complete the following checklist:
npm test
) all passyarn run prettier
).yarn run typecheck
).Here is a short checklist of additional things to keep in mind before submitting:
Since update to React 19-rc.1 (which is part of the latest NextJS 15) these functionalities started to fail (at least in the app we have). These changes helped avoid usages of
findDOMNode
that has been removed as well asdefaultProps
which didn't have an effect "from outside" all these settings were empty. Cannot say it's complex support for the latest React, but it's a great start.