Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from classnames to clsx #1306

Merged
merged 1 commit into from
Jan 13, 2019
Merged

Migrate from classnames to clsx #1306

merged 1 commit into from
Jan 13, 2019

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jan 11, 2019

  • esm support
  • smaller without umd wrapper
  • probably faster

- esm support
- probably faster
@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #1306 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1306   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          59       59           
  Lines        1738     1738           
=======================================
  Hits         1571     1571           
  Misses        167      167
Impacted Files Coverage Δ
source/Collection/CollectionView.js 90.19% <ø> (ø) ⬆️
source/Grid/Grid.js 94.44% <ø> (ø) ⬆️
source/Masonry/Masonry.js 95.45% <ø> (ø) ⬆️
source/List/List.js 75% <100%> (ø) ⬆️
source/Table/Table.js 89.09% <100%> (ø) ⬆️
source/Table/SortIndicator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf418c...3b158e4. Read the comment docs.

Copy link
Contributor

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wuweiweiwu wuweiweiwu merged commit 2c99340 into master Jan 13, 2019
@TrySound TrySound deleted the clsx branch January 13, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants