make test in react-test-renderer painless #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuweiweiwu
suggested changes
May 24, 2018
There was a problem hiding this comment.
@nihgwu Can you add a test that uses 'react-test-renderer' to render Grid?
Looks good!
|
Done, without this change, the tests will fail |
|
BTW, can we release a new version? that breaks all my test cases, now I have to use a wrapper to apply the mock option, also I don't think that's the desired solution, as that would make people thought I was using refs in |
wuweiweiwu
approved these changes
May 25, 2018
|
Thanks for contributing @nihgwu ! |
|
this is released in 9.20.0! |
|
a work around is to use |
|
@wuweiweiwu Excellent! This is really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1117