Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Panel pointer-events during resize #66

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Disable Panel pointer-events during resize #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc2681
Disable pointer events during resize
bvaughn Jan 5, 2023
4cac9e6
CHANGELOG
bvaughn Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-resizable-panels/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 0.0.29
* [#58](https://github.com/bvaughn/react-resizable-panels/pull/58): Add imperative `collapse`, `expand`, and `resize` methods to `Panel`.
* [#64](https://github.com/bvaughn/react-resizable-panels/pull/64): Disable `pointer-events` inside of `Panel`s during resize. This avoid edge cases like nested iframes.
* [#57](https://github.com/bvaughn/react-resizable-panels/pull/57): Improve server rendering check to include `window.document`. This more closely matches React's own check and avoids false positives for environments that alias `window` to some global object.

## 0.0.28
Expand Down
6 changes: 5 additions & 1 deletion packages/react-resizable-panels/src/PanelGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,13 @@ export function PanelGroup({

// Without this, Panel sizes may be unintentionally overridden by their content.
overflow: "hidden",

// Disable pointer events inside of a panel during resize.
// This avoid edge cases like nested iframes.
pointerEvents: activeHandleId !== null ? "none" : undefined,
};
},
[direction, sizes]
[activeHandleId, direction, sizes]
);

const registerPanel = useCallback((id: string, panel: PanelData) => {
Expand Down