Don't cancel resize operations when exiting the window #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NMinhNguyen
reviewed
Dec 29, 2022
| document.body.removeEventListener("mousemove", onMove); | ||
| document.body.removeEventListener("touchmove", onMove); | ||
| document.body.removeEventListener("mouseup", stopDraggingAndBlur); | ||
| window.removeEventListener("mouseup", stopDraggingAndBlur); | ||
| window.removeEventListener("touchend", stopDraggingAndBlur); |
There was a problem hiding this comment.
Not for right now, but I wonder if you'll need to eventually derive (or accept) the correct document and window to support rendering into iframes / child windows opened via window.open()
There was a problem hiding this comment.
Maybe! I guess it depends on where this thing gets used. This works for now 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only cancel when a
"mouseup"(or"touchend") event is fired.Resolves #42