Use a nicer list reporter locally
#356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Andarist
commented
May 10, 2024
| : undefined, | ||
| // replicating Playwright's defaults | ||
| process.env.CI ? (["dot"] as const) : (["list"] as const), | ||
| ].filter((v): v is NonNullable<typeof v> => !!v), |
There was a problem hiding this comment.
with the upcoming TS 5.5 you will be able to rewrite this as:
Suggested change
| ].filter((v): v is NonNullable<typeof v> => !!v), | |
| ].filter(v => !!v), |
bvaughn
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the complaint from #348 (comment) . I didn't realize that the default is
'list'locally, I added'line'reporter since I've seen that being used in a couple of other projects. I totally agree that'list'is quite nice and I prefer it to'line'- especially if we consider smaller test suites.@replayio/playwrightstill spits out a bunch of junk into the stdout. That makes the current output very cluttered - even with this improvement. This is going to be addressed with PRO-315