Version 1.0 release #230
Merged
Version 1.0 release #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Dec 10, 2023
|
@bvaughn is there a possibility that you could consider putting back pixel constraints into the library in the future, given a simpler and more straightforward solution would be found? |
|
It's possible but it's not a priority for me. |
|
Are there any userland workarounds to be able to enforce minimum or maximum size in pixels? |
|
From the README on this PR: Can panel sizes be specified in pixels?No. Pixel-based constraints added significant complexity to the initialization and validation logic and so I've decided not to support them. You may be able to implement a version of this yourself following a pattern like this but it is not officially supported by this library. |
… Simplified some e2e tests by moving them into unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
dataAttributesprop with ...rest (to support all HTMLAttributes)dragStateis null #224I think this library's feature set is stable enough in my mind for a 1.0 release. It might be controversial but I have decided to cut pixel-based constraints from that release as they added too much complexity to the initialization and validation logic.