-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore generic types #37
Comments
Any changes will be done only after war, as I am in active service right
now. It’s more important.
…On Wed, 6 Apr 2022 at 11:04, Pål Marius Sivertsen ***@***.***> wrote:
ireturn should ignore generic type parameters.
I get an error when using ireturn on this code:
package example
type Map[K comparable, V any] map[K]V
func (m Map[K, V]) Get(key K) V { return m[key] }
[image: image]
<https://user-images.githubusercontent.com/11890143/161926131-9e5f4acd-968e-40eb-b7fc-9286a03138e1.png>
golangci-lint has version 1.45.2 built from 8bdc4d3f on
2022-03-24T11:51:26Z
—
Reply to this email directly, view it on GitHub
<#37>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7EMAAIAWFKENJA664MYDVDVASFANCNFSM5SVFI7XA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Stay strong! |
@butuzov Any progress? |
@iwata well...we took some lands back, more to go. As for this feature, no wasn't using editor since 25th february as I am at war. Man i wish to back to coding, but there are more important things when you country trying to survive. |
I believe this is still an issue. |
Also an issue for me with golangci-lint 1.54.2. |
due to golang/go#50956 I must to drop check for typeParams (which is `nil` for methods). So from now on, i am checking if param is interface implementation, then exclude one by one interface types. Added new tests. closes #37
* dev: Fix for missing TypeParams in methods due to golang/go#50956 I must to drop check for typeParams (which is `nil` for methods). So from now on, i am checking if param is interface implementation, then exclude one by one interface types. - Added new tests. - Added compatibility code (to align with go1.18 and go1.19 type params representation) closes #37
You can now build it from sources, and i will release new version as soon as go1.22 releases and I be alive till that momemnt. |
ireturn
should ignore generic type parameters.I get an error when using
ireturn
on this code:golangci-lint has version 1.45.2 built from 8bdc4d3f on 2022-03-24T11:51:26Z
The text was updated successfully, but these errors were encountered: