Add Post Recommendation component #813

jm90m · 2017-10-16T14:57:47Z

WIP - Add Post Recommendation component

jm90m · 2017-10-17T01:20:06Z

Updated based on feedback from trello card: https://trello.com/c/9ZM6ctlZ/118-single-post-sidebar-right-component-post-recommendation

mynameisek · 2017-10-17T02:20:28Z

When user clicks on a link from the component, he should land on the Top of the page. In the current situation it keeps the scroll position.

bonustrack · 2017-10-17T13:29:11Z

Post recommendation should also appear for unlogged users
I can see that 2 request are being sent when opening a post see:

There should be only 1 request and the limit should be 6 (For showing 5 lastest post without current post)
This border should not appear in last post recommended:
More from username should not be centered
There should be an icon near title, similar than "Interesting People", you can use the icon headlines
The title "More from username" should have same style than "Interesting People" title.
We should see username in post recommendation too

bonustrack · 2017-10-17T13:42:41Z

Idealy we should use same class for all box title and avoid duplicate code.

jm90m · 2017-10-17T20:04:49Z

@bonustrack made adjustments based on your feedback, also added the scroll to top on click of post navigation as @mynameisek requested.

So for the limit in the request, I had it set to 20 since posts that are 'resteemed/reblogged' get sent back in the request, is there any way just to get the post authored by user not the resteemed one?

jm90m · 2017-10-17T20:07:06Z

Also added icon, and use same classname / removed duplicate styling on header title for both sidebar blocks, Interesting People and Post Recommendation titles

bonustrack · 2017-10-17T20:14:16Z

@jm90m we need only 6 result because we want also the resteemed ones. There is no way to get only post from author with the blockchain API, for some account like my account, you would need to paginate too much to get 5 post from me. You can change the title to "Recommended Posts".

bonustrack · 2017-10-17T20:15:33Z

Or "Interesting Posts" ?

jm90m · 2017-10-17T20:18:14Z

Oh I see what you mean @bonustrack, so instead of the More from <username>, it will be either "Recommended Posts" or "Interesting Posts", then we should also display the author maybe in between title and number of comments. I think "Recommended Posts" makes more sense here, since the PostRecommendation components get posts that are authored/resteemed by the current author of the post that you are viewing.

bonustrack · 2017-10-17T20:19:31Z

Can you align Title and comment in red line?

bonustrack · 2017-10-17T20:23:46Z

Can you add this style to Post title:
font-size: 15px; and font-weight: bold;
And font-size: 15px; for the "100 comments"

jm90m · 2017-10-17T20:38:36Z

@bonustrack updated styles as you suggested, also added the author in each post recommended, with Link to post author

jm90m · 2017-10-17T20:40:53Z

alignment should be correct now too:

bonustrack · 2017-10-17T20:51:56Z

Sorry can you set size of title back to 16px (keep other text to 15px).
And show only 3 stories (request with limit 4)
Also link comment to post url /tag/@author/permlink#comments

jm90m · 2017-10-17T21:00:31Z

@bonustrack Post title should now be 16px while all others are at 15px, limited the stories to 4, and added link to comments

…link to match `by`

* also use steemAPI directly rather than go through actions to avoid going through reducers

bonustrack · 2017-10-20T12:08:54Z

Not sure if you waiting a review here but i still see 2 requests

bonustrack · 2017-10-25T14:09:10Z

Can you see the 2 request too @Sekhmet ?

bonustrack

Looking good! The last changes seem to fixed the issue with 2 request been sent.

Sekhmet · 2017-10-25T16:29:09Z

I think that it would look better with even space above and below heading (now it has 8 pixels at top and 12 pixels at bottom.

I think that this padding is too big now:

I think that we should use padding-bottom: 0px for .PostRecommendation__link:last-of-type.

Sekhmet · 2017-10-25T16:30:07Z

src/components/Sidebar/PostRecommendation.js

+        <h4 className="PostRecommendation__title SidebarBlock__content-title">
+          <i className="iconfont icon-headlines PostRecommendation__icon" />
+          {' '}
+          {intl.formatMessage({ id: 'recommended_posts', defaultMessage: 'Recommended Posts' })}


Can we use FormattedMessage whenever possible?

…onent

jm90m · 2017-10-25T18:43:35Z

@Sekhmet alright made those changes that you suggested

Sekhmet · 2017-10-25T19:03:16Z

I think that you missed first point from my review about uneven space around title. In my opinion it looks better with 8/8 pixels margins instead of 8/12. Could we change that? What do you think @bonustrack?

bonustrack · 2017-10-25T19:09:37Z

You mean this @Sekhmet ?

jm90m · 2017-10-25T19:11:08Z

@Sekhmet @bonustrack ahh i see what you mean, ill make another PR for it

bonustrack · 2017-10-25T21:51:44Z

@jm90m just found something. Now the component "Interesting People" appear also when unlogged. It's supposed to appear only to logged users, can you revert that too?

jm90m · 2017-10-25T23:25:56Z

@bonustrack so only show "Interesting People" component for authenticated users?

jm90m · 2017-10-26T00:57:23Z

@bonustrack I hide Interesting People section for unathenticated users in my PR here: #857

jm90m added the PR: WIP label Oct 16, 2017

bonustrack temporarily deployed to busy-dev-pr-813 October 16, 2017 14:57 Inactive

bonustrack temporarily deployed to busy-dev-pr-813 October 17, 2017 01:18 Inactive

jm90m added feature and removed PR: WIP labels Oct 17, 2017

jm90m requested a review from bonustrack October 17, 2017 01:19

jm90m removed the feature label Oct 17, 2017

bonustrack added the feature label Oct 17, 2017

jm90m force-pushed the nd/add-single-post-recommendation-component branch from 49868a7 to b0e425d Compare October 17, 2017 18:23

bonustrack temporarily deployed to busy-dev-pr-813 October 17, 2017 18:24 Inactive

bonustrack temporarily deployed to busy-dev-pr-813 October 17, 2017 19:00 Inactive

jm90m force-pushed the nd/add-single-post-recommendation-component branch from aa2cf6b to fd19b7b Compare October 17, 2017 20:37

bonustrack temporarily deployed to busy-dev-pr-813 October 17, 2017 20:37 Inactive

bonustrack temporarily deployed to busy-dev-pr-813 October 17, 2017 20:57 Inactive

bonustrack temporarily deployed to busy-dev-pr-813 October 17, 2017 21:00 Inactive

jm90m added 6 commits October 19, 2017 17:29

Fix overflow of text in post recommendation, change color of comment …

6d13adb

…link to match `by`

Cancel postRecommendation promise on componentUnmount

b839340

update RightSidebar shouldComponentUpdate

0a396d0

Fix multiple render issue for PostRecommendation

aefd907

* also use steemAPI directly rather than go through actions to avoid going through reducers

Load posts by author when navigating

0809d4e

Add authFetching check to PostRecommendation component

e95a28f

jm90m force-pushed the nd/add-single-post-recommendation-component branch from 776ebed to e95a28f Compare October 19, 2017 22:08

bonustrack temporarily deployed to busy-dev-pr-813 October 19, 2017 22:08 Inactive

Refactor Signup Logic out

9773bc1

bonustrack temporarily deployed to busy-dev-pr-813 October 25, 2017 14:09 Inactive

bonustrack approved these changes Oct 25, 2017

View reviewed changes

Sekhmet self-requested a review October 25, 2017 16:25

Sekhmet reviewed Oct 25, 2017

View reviewed changes

Remove padding from last post recommendation and use FormattedMessage

cebafe1

bonustrack deployed to busy-dev-pr-813 October 25, 2017 18:40 View deployment

Merge branch 'new-design' into nd/add-single-post-recommendation-comp…

61f91a7

…onent

bonustrack requested a deployment to busy-dev-pr-813 October 25, 2017 18:41 Pending

jm90m merged commit 528fa8c into new-design Oct 25, 2017

jm90m deleted the nd/add-single-post-recommendation-component branch October 25, 2017 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Post Recommendation component #813

Add Post Recommendation component #813

jm90m commented Oct 16, 2017

jm90m commented Oct 17, 2017

mynameisek commented Oct 17, 2017

bonustrack commented Oct 17, 2017 •

edited

Loading

bonustrack commented Oct 17, 2017 •

edited

Loading

jm90m commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 17, 2017

bonustrack commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 17, 2017

bonustrack commented Oct 17, 2017

jm90m commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 20, 2017

bonustrack commented Oct 25, 2017

bonustrack left a comment

Sekhmet commented Oct 25, 2017

Sekhmet Oct 25, 2017

jm90m commented Oct 25, 2017

Sekhmet commented Oct 25, 2017

bonustrack commented Oct 25, 2017

jm90m commented Oct 25, 2017

bonustrack commented Oct 25, 2017

jm90m commented Oct 25, 2017

jm90m commented Oct 26, 2017

Add Post Recommendation component #813

Add Post Recommendation component #813

Conversation

jm90m commented Oct 16, 2017

jm90m commented Oct 17, 2017

mynameisek commented Oct 17, 2017

bonustrack commented Oct 17, 2017 • edited Loading

bonustrack commented Oct 17, 2017 • edited Loading

jm90m commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 17, 2017

bonustrack commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 17, 2017

bonustrack commented Oct 17, 2017

jm90m commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 17, 2017

jm90m commented Oct 17, 2017

bonustrack commented Oct 20, 2017

bonustrack commented Oct 25, 2017

bonustrack left a comment

Choose a reason for hiding this comment

Sekhmet commented Oct 25, 2017

Sekhmet Oct 25, 2017

Choose a reason for hiding this comment

jm90m commented Oct 25, 2017

Sekhmet commented Oct 25, 2017

bonustrack commented Oct 25, 2017

jm90m commented Oct 25, 2017

bonustrack commented Oct 25, 2017

jm90m commented Oct 25, 2017

jm90m commented Oct 26, 2017

bonustrack commented Oct 17, 2017 •

edited

Loading

bonustrack commented Oct 17, 2017 •

edited

Loading