Editor link tooltips can be disabled #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mattmcmanus! This makes sense to me. As an alternative, did you consider using CSS to hide the tooltip? |
|
@bantic That makes sense and would probably work. It seemed like a good idea to disable setting them up though to prevent the listeners from needing to be in place. |
|
Yeah, I agree. I did some work to fix up CI. Restarting your build now... |
|
Actually, this needs a rebase in order to pick up the changes to the travis yml. I'll proactively merge and review in case any tests fail after that. 👍 |
|
Yay! If all goes well, @lukemelia and I will a lot more to add over the coming weeks! |
|
released in v0.10.21 https://github.com/bustle/mobiledoc-kit/releases/tag/v0.10.21 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to disable tooltips for links in the editor. There are currently no tests that I could see for them. If you have thoughts about how you'd like to test this, please let me know.
ember-mobiledoc-editorPR forthcoming.