37 selection deletion #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // add a blank marker to any sections that are now empty | ||
| changedSections.forEach(section => { | ||
| if (section.isEmpty()) { | ||
| section.appendMarker(Marker.createBlank()); |
There was a problem hiding this comment.
Should go through the builder?
bantic
force-pushed
the
37-selection-deletion
branch
from
96bbe82
to
1c1f04b
Compare
4 tasks
|
@bantic beside that comment on |
|
Because if you merge before #48 I'll do the rebase for |
This was referenced Aug 9, 2015
|
:) thanks! I can help with rebasing cutMarkers if you need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
post#cutMarkers(markers)andeditor#deleteSelection.Also adds
Helpers.toolbarfor sharing toolbar-related assertions in tests, andHelpers.dom.triggerDelete, which detects phantom and simulates a delete (by callingeditor.handleDeletion) — this allows some of the previous skipped-in-phantom tests to run in phantom, now.Ready for review. I will start on the items below but make a separate PR for them. @mixonic lmk if you have feedback.
To do: