Blur element focus on destroy, add null/blank demos #279
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
added a commit
that referenced
this pull request
Dec 31, 2015
Blur element focus on destroy, add null/blank demos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References bustle/ember-mobiledoc-editor#42 (comment)
On destroy the element was not blurred, meaning a subsequent editor attached to that node would need to handle keystrokes on the editor element (and no cursor was visible). Instead destroy should remove the focus.
Also add some new demos to test null and blank mobiledocs with ember-mobiledoc-editor.