Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #256: Copy-pasting from Notepad does not work #262

Merged
merged 1 commit into from
Dec 14, 2015
Merged

Fix issue #256: Copy-pasting from Notepad does not work #262

merged 1 commit into from
Dec 14, 2015

Conversation

YoranBrondsema
Copy link
Collaborator

A PR that addresses #256. Fallback to text/plain if text/html is empty.

@bantic
Copy link
Collaborator

bantic commented Dec 14, 2015

Thanks! As written, this continues to use the HTMLParser to parse the plaintext, so if someone copied the text "abc <b>bold</b>" it would get pasted as "abc bold". Ideally there would be a text parser in addition to the HTML parser, and it could interpret pasted plaintext into mobiledoc (also splitting into multiple sections by linebreak, for instance).
I'm going to merge this and add an issue to use an actual text parser. If you have interest in tackling that you would be welcome to, otherwise I should get to it sometime this week.
thanks @YoranBrondsema !

bantic added a commit that referenced this pull request Dec 14, 2015
Fix issue #256:  Copy-pasting from Notepad does not work
@bantic bantic merged commit 15dfb9e into bustle:master Dec 14, 2015
@YoranBrondsema
Copy link
Collaborator Author

Ah true, hadn't thought of that case. Well at least we have a semi-functional plaintext pasting functionality now so thanks for merging! I'll see what I can do this week, I might find some time to tackle this as well. I'll let you know in #263 if I start working on it so we don't do double work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants