Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing in link causes console error #98

Closed
bantic opened this issue Aug 27, 2015 · 0 comments · Fixed by #106
Closed

typing in link causes console error #98

bantic opened this issue Aug 27, 2015 · 0 comments · Fixed by #106
Assignees

Comments

@bantic
Copy link
Collaborator

bantic commented Aug 27, 2015

On Mac, Chrome:
Select some text, use the toolbar to create a link, and then type text in the link. Causes console error: "Cannot read property 'parentNode' of undefined".

This appears to be due to the fact that, although we reparse after the link command calls document.execCommand('createLink'), we don't rerender the new markers. They end up in the Abstract Tree but their rendered elements are not in the element map, so the next time we type -> reparse -> rerender, we cannot tear down those markers.

@bantic bantic self-assigned this Aug 31, 2015
bantic added a commit that referenced this issue Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant