Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markup cache is skipped for markups with attributes #140

Closed
bantic opened this issue Sep 16, 2015 · 0 comments · Fixed by #141
Closed

Markup cache is skipped for markups with attributes #140

bantic opened this issue Sep 16, 2015 · 0 comments · Fixed by #141
Assignees
@bantic

Comments

@bantic
Copy link
Collaborator

bantic commented Sep 16, 2015

Any markup with attributes (e.g., a link) skips the markup cache and pollutes the head of the mobiledoc with many identical markups.
@bantic bantic self-assigned this Sep 16, 2015
bantic added a commit that referenced this issue Sep 16, 2015
@bantic
ensure we cache markups with attributes properly
1ae3cfa 
Also change markup creation to use an object of attrs rather than an array

fixes #140
@bantic bantic mentioned this issue Sep 16, 2015
Merged
bantic added a commit that referenced this issue Sep 16, 2015
@bantic
ensure we cache markups with attributes properly
7436f0d 
Also change markup creation to use an object of attrs rather than an array

fixes #140
bantic added a commit that referenced this issue Sep 16, 2015
@bantic
ensure we cache markups with attributes properly
a46c26e 
Also change markup creation to use an object of attrs rather than an array

fixes #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure we cache markups with attributes properly bustle/mobiledoc-kit
1 participant
@bantic