Skip to content

Commit

Permalink
Use "version" script instead of postversion with --amend --no-edit
Browse files Browse the repository at this point in the history
Using --amend --no-edit was changing the sha of the commit *after* it
had been tagged, which caused issues with future updates to the
changelog. The `git-semver-commits` package failed to find tags when
their commits were amended post-tagging.
  • Loading branch information
bantic committed Aug 4, 2016
1 parent 7e177e3 commit 13abc9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"deploy-website": "./bin/deploy-website.sh",
"update-changelog": "conventional-changelog -i CHANGELOG.md -r 0 -s",
"docs": "jsdoc -c ./.jsdoc",
"postversion": "npm run update-changelog && git add CHANGELOG.md && git commit --amend --no-edit",
"version": "npm run update-changelog && git add CHANGELOG.md",
"prepublish": "npm run build"
},
"keywords": [
Expand Down

0 comments on commit 13abc9d

Please sign in to comment.