Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove cards and atoms before teardown or re-rendering. #20

Closed
wants to merge 1 commit into from

Conversation

abuiles
Copy link

@abuiles abuiles commented Oct 13, 2016

I was getting trolled with the following error:

Assertion failed: Error: ember-wormhole failed to render into '#__rendered-mobiledoc-entity-1332' because the element is not in the DOM(…)

After chasing it down, the problem was that the editor was being teardown while cards and atoms were still in the list, so wormhole was trying to render but failing.

@bantic I think this is also related with #19

It would be nice to add some tests, but I haven't had the time to do that yet.

@bantic
Copy link
Contributor

bantic commented Oct 13, 2016

@abuiles I think PR #23 addresses the same issue you're reporting here. It's merged and released on a beta version v0.5.3-beta.1. Could you try that out and see if it fixes the issues you've seen in your app? thanks!

@abuiles abuiles closed this Oct 13, 2016
@abuiles
Copy link
Author

abuiles commented Oct 13, 2016

@bantic I'm not 100% sure if this fixes the original issue or not, but now we have a new problem, cards are not being rendered I put an example app where you can see the issue https://github.com/abuiles/_______ember-mobiledoc-dom-playground

This is what I used to get http://s.abuiles.com/2s2i343p0L0e and this is after upgrading to beta http://s.abuiles.com/0e2M2R0i0W2z

@abuiles abuiles deleted the wormhole-bug branch October 13, 2016 23:40
@abuiles abuiles restored the wormhole-bug branch October 13, 2016 23:40
lukemelia pushed a commit to yapplabs/ember-mobiledoc-dom-renderer that referenced this pull request Aug 19, 2019
…-runloop-render-safe-way

add/remove components within runloop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants