Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Noise CI in ACF Plots #85

Closed
AlbertoAlmuinha opened this issue Jun 25, 2021 · 2 comments
Closed

White Noise CI in ACF Plots #85

AlbertoAlmuinha opened this issue Jun 25, 2021 · 2 comments

Comments

@AlbertoAlmuinha
Copy link

Hi @mdancho84 ,

I open this issue because I would really like to talk about plot_acf_diagnostics().

I would like to propose to change the ".show_white_noise_bars" argument of this function by default to TRUE. I really don't understand what is the reason to have it default to FALSE, since seeing the confidence intervals (at least in my opinion) seems to me something really important in this visualization and therefore I think it should be already there from the beginning. Although it may seem silly to change it, it took me some time to realize which was the argument I had to modify to activate this option (in fact, at the beginning I thought that this option did not exist).

Let's comment.

Best regards,

@mdancho84
Copy link
Contributor

I've just updated this. Give it a look. https://business-science.github.io/timetk/reference/plot_acf_diagnostics.html

@AlbertoAlmuinha
Copy link
Author

Perfect @mdancho84 , that’s ok for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants