Skip to content

Commit

Permalink
fix: disable deterministic NuGet packaging which causes failures for …
Browse files Browse the repository at this point in the history
…users in UTC >0 timezones

Workaround NuGet/Home#7001, NuGet/Home#8603
  • Loading branch information
busgaidw2 authored and natemcmaster committed Sep 18, 2019
1 parent dd3c0bd commit 742ef89
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

[See unreleased changes][unreleased].

## [v2.4.1]

* Fix [#277] - workaround a bug in NuGet's 'deterministic packaging' feature which causes issues based on your timezone

## [v2.4.0]

* Fix [#227] by [@ejball] - ArgumentEscaper should escape empty string
Expand Down
10 changes: 10 additions & 0 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,14 @@
<Target Name="UpdateCiSettings" Condition="'$(CI)' == 'true' AND '$(OS)' == 'Windows_NT' AND '$(IsPackable)' == 'true'">
<Message Importance="High" Text="##vso[build.updatebuildnumber]$(PackageVersion)" />
</Target>


<!-- Workaround https://github.com/NuGet/Home/issues/7001 -->
<Target Name="DisableNuGetDeterministicPackaging"
BeforeTargets="GenerateNuspec"
AfterTargets="CoreCompile">
<PropertyGroup>
<Deterministic>false</Deterministic>
</PropertyGroup>
</Target>
</Project>
6 changes: 5 additions & 1 deletion src/CommandLineUtils/releasenotes.props
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<PropertyGroup>
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.0'">
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.1'">
Features and bug fixes by some awesome contributors:

* @IanG: Attributes for files and directories that must not exist
Expand All @@ -16,6 +16,10 @@ Other things I fixed:
* Add async methods that accept cancellation tokens
* Handle CTRL+C by default
* Support calling CommandLineApplication.Execute multiple times

2.4.1 hot fix:
* Workaround a bizarre NuGet bug which causes problems for users in Europe and Asia
(see https://github.com/NuGet/Home/issues/8603)
</PackageReleaseNotes>

<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.3.4'">
Expand Down
6 changes: 5 additions & 1 deletion src/Hosting.CommandLine/releasenotes.props
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
<Project>
<PropertyGroup>
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.0'">
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.1'">
Changes:
* Support C# 8.0 and nullable reference types
* RunCommandLineApplicationAsync is actually async now, not just sync disguised as an async API
* Better CTRL+C support

2.4.1 hot fix:
* Workaround a bizarre NuGet bug which causes problems for users in Europe and Asia
(see https://github.com/NuGet/Home/issues/8603)
</PackageReleaseNotes>
<PackageReleaseNotes>$(PackageReleaseNotes)

Expand Down

0 comments on commit 742ef89

Please sign in to comment.