5.4.1221

burakoner · Dec 21, 2024 · af95c28 · af95c28
1 parent 597e35f
commit af95c28
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## Change Log & Release Notes
 
-* Version 5.4.1219 - 25 Oct 2024
+* Version 5.4.1221 - 21 Dec 2024
+
+* Version 5.4.1219 - 19 Dec 2024
   * Fixed issue [#73](https://github.com/burakoner/OKX.Api/issues/73)
 
 * Version 5.4.1217 - 17 Dec 2024

diff --git a/OKX.Api/OKX.Api.csproj b/OKX.Api/OKX.Api.csproj
@@ -9,10 +9,10 @@
 	<PropertyGroup>
 		<PackageId>OKX.Api</PackageId>
 		<Authors>Burak Öner</Authors>
-		<Version>5.4.1219</Version>
-		<FileVersion>5.4.1219</FileVersion>
-		<PackageVersion>5.4.1219</PackageVersion>
-		<AssemblyVersion>5.4.1219</AssemblyVersion>
+		<Version>5.4.1221</Version>
+		<FileVersion>5.4.1221</FileVersion>
+		<PackageVersion>5.4.1221</PackageVersion>
+		<AssemblyVersion>5.4.1221</AssemblyVersion>
 		<Description>OKX V5 Api Wrapper. Up-to-date, most-complete, well-organized, well-documented, easy-to-use, multi-task and multi-thread compatible OKX Cryptocurrency Exchange Rest and Websocket Api Wrapper</Description>
 		<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
 		<PackageTags>OKX;OKEX;Binance;BNB;BTC;Api;Client;Rest;Web;Websocket;Socket;Wrapper;Crypto;Currency;Cryptocurrency;Exchange;Trade;Trading;Bitcoin;Spot;Margin;Futures;Derivates;Stock;Options;Swap;</PackageTags>
@@ -25,6 +25,7 @@
 		<RepositoryUrl>https://github.com/burakoner/OKX.Api</RepositoryUrl>
 		<GenerateDocumentationFile>True</GenerateDocumentationFile>
 		<ProduceReferenceAssembly>True</ProduceReferenceAssembly>
+		<PackageReadmeFile>README.md</PackageReadmeFile>
 	</PropertyGroup>
 
 	<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|netstandard2.0|AnyCPU'">
@@ -47,10 +48,6 @@
 		<None Include="OKX.png" Pack="true" PackagePath="" />
 	</ItemGroup>
 
-	<PropertyGroup>
-		<PackageReadmeFile>README.md</PackageReadmeFile>
-	</PropertyGroup>
-
 	<ItemGroup>
 		<None Include="../CHANGELOG.md" Pack="true" PackagePath="\" />
 		<None Include="../README.md" Pack="true" PackagePath="\" />

diff --git a/OKX.Api/OkxWebSocketApiOptions.cs b/OKX.Api/OkxWebSocketApiOptions.cs
@@ -10,11 +10,6 @@ public class OkxWebSocketApiOptions : WebSocketApiClientOptions
     /// </summary>
     public bool DemoTradingService { get; set; } = false;
 
-    /// <summary>
-    /// Broker ID
-    /// </summary>
-    public string BrokerId { get; set; } = OkxConstants.BrokerId;
-
     /// <summary>
     /// Constructor
     /// </summary>

diff --git a/OKX.Api/Trade/Clients/OkxTradeSocketClient.cs b/OKX.Api/Trade/Clients/OkxTradeSocketClient.cs
@@ -106,7 +106,7 @@ public async Task<CallResult<WebSocketUpdateSubscription>> SubscribeToFillsAsync
     /// <returns></returns>
     public async Task<CallResult<OkxTradeOrderPlaceResponse>> PlaceOrderAsync(OkxTradeOrderPlaceRequest request)
     {
-        request.Tag = Options.BrokerId;
+        request.Tag = OkxConstants.BrokerId;
         var req = new OkxSocketRequest<OkxTradeOrderPlaceRequest>(_.RequestId().ToString(), OkxSocketOperation.Order, [request]);
         return await _.RootQueryAsync<OkxTradeOrderPlaceResponse>(OkxSocketEndpoint.Private, req, true).ConfigureAwait(false);
     }
@@ -118,7 +118,7 @@ public async Task<CallResult<OkxTradeOrderPlaceResponse>> PlaceOrderAsync(OkxTra
     /// <returns></returns>
     public async Task<CallResult<IEnumerable<OkxTradeOrderPlaceResponse>>> PlaceOrdersAsync(IEnumerable<OkxTradeOrderPlaceRequest> requests)
     {
-        foreach (var order in requests) order.Tag = Options.BrokerId;
+        foreach (var order in requests) order.Tag = OkxConstants.BrokerId;
         var req = new OkxSocketRequest<OkxTradeOrderPlaceRequest>(_.RequestId().ToString(), OkxSocketOperation.BatchOrders, requests);
         return await _.RootQueryAsync<IEnumerable<OkxTradeOrderPlaceResponse>>(OkxSocketEndpoint.Private, req, true).ConfigureAwait(false);
     }