Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strictly typed BunqResponses #52

Closed
dnl-blkv opened this issue Sep 25, 2017 · 0 comments
Closed

Add strictly typed BunqResponses #52

dnl-blkv opened this issue Sep 25, 2017 · 0 comments
Assignees
@dnl-blkv
Labels
enhancement

Comments

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Sep 25, 2017 •
edited
Loading

How to Reproduce

  1. Write code to make a request via the SDK
  2. Write a code using the response of the request from (1)

What Should Happen

  1. The $response.getValue() has a strict type in doc block, and the IDE auto-completion works on it

What Happens

  1. The $response.getValue() doesn't have a strict type in doc block and therefore IDE auto-completion doesn't work on it
@dnl-blkv dnl-blkv self-assigned this Sep 25, 2017
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
Add strictly typed responses; fix GET in extended models [#52]
00e223b
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
Add strict BunqResponse typecasts [#52]
b48fd00
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
remove extra constructs [#52]
5d3b6ba
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
cleanup JsonParserTest; fix doc return types for mixed arrays [#52]
76d4949
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
fix namespaces [#52]
f547178
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
fix docs for generated objects [#52]
5410548
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
fix a few phpstan errors [#52]
3ad99fd
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
fix minor formatting issues [#52]
706b0f8
@dnl-blkv dnl-blkv mentioned this issue Sep 25, 2017
Merged
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
fix location of tests [#52]
716eb9a
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
fix reference to attachment [#52]
33d529a
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
Fix types of Context [#52]
fdb382b
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
update types in Http [#52]
fc0e1cd
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
rearrange code [#52]
b123489
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
fix types for Model [#52]
51b1900
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
Add missing phpcd; fix types of Security [#52]
60dc6b1
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
fix typing in the rest of src/ and example/ [#52]
c7d31a3
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
Use strict typing for all the non-generated code [#52]
fe6a1c1
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
exclude Generated from phpcpd [#52]
b2634e1
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
Add strict types for BunqResponse's and endpoint methods [#52]
b918975
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
fix gitignore [#52]
4b4277c
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
adjust grumphp timeout [#52]
f879802
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
Temporarily remove strict types from getters/setters/constructors; ad…
4ea10a0 
…d missing strict type for listings [#52]
dnl-blkv added a commit that referenced this issue Oct 5, 2017
@dnl-blkv
fix attachments of ScheduleRequestInquiryEntry [#52]
76f8273
dnl-blkv added a commit that referenced this issue Oct 5, 2017
@dnl-blkv
improve import ordering; utilize try/ctach [#52]
53870a9
dnl-blkv added a commit that referenced this issue Oct 6, 2017
@dnl-blkv
organize imports [#52]
2aceb13
andrederoos added a commit that referenced this issue Oct 6, 2017
@andrederoos
Merge pull request #53 from bunq/52-strict-response
6c670c2 
Add strictly typed responses; fix GET in extended models [#52]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnl-blkv dnl-blkv

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dnl-blkv