Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separation of concerns: InstallationUtil class is displaying error messages #133

Closed
jorijn opened this issue Apr 7, 2018 · 0 comments · Fixed by #136
Closed

Separation of concerns: InstallationUtil class is displaying error messages #133

jorijn opened this issue Apr 7, 2018 · 0 comments · Fixed by #136
Assignees
@jorijn @OGKevin
Labels
enhancement
Milestone
1.0.0

Comments

@jorijn
Copy link
Contributor

jorijn commented Apr 7, 2018 •
edited by OGKevin
Loading

Steps to reproduce:

  1. Use the InstallationUtil to create ApiContext
  2. Be in such state than an exception is thrown

What should happen:

  1. InstallationUtil should throw the exception.
  2. The exception is not caught, displaying the whole stack trace instead of the main error message.

What happens:

  1. InstallationUtil is catching the exception and printing it, instead of terminating the code execution.

needs #137
@jorijn jorijn mentioned this issue Apr 7, 2018
Closed
1 task
@OGKevin OGKevin added this to the 0.13.5 milestone Apr 7, 2018
jorijn added a commit to jorijn/sdk_php that referenced this issue Apr 7, 2018
@jorijn
separated responsibilities: displaying the error message belongs to t…
4fff756 
…he `bunq-install` script, the `InstallationUtil` class should just throw exceptions when something goes south (bunq#133)
@jorijn jorijn mentioned this issue Apr 7, 2018
Merged
1 task
OGKevin pushed a commit to jorijn/sdk_php that referenced this issue Apr 7, 2018
@jorijn @OGKevin
Displaying the error message belongs to the bunq-install script. (bun…
7972a37 
…q#133)
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 7, 2018
@OGKevin
Import the classes instead of using them by namspace. (bunq#133)
5beefbf
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 7, 2018
@OGKevin
Fixed some formatting issues. (bunq#133)
17ff885
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 7, 2018
@OGKevin
Made context file optional. (bunq#133)
dbc78e3
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 7, 2018
@OGKevin
Moved logic to its own method. (bunq#133)
f1c5498
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 7, 2018
@OGKevin
Ran atuo formatter. (bunq#133)
232d972
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 9, 2018
@OGKevin
Removed is null checks for file name in installationUtil. (bunq#133)
ecb86bb
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 9, 2018
@OGKevin
Removed plurals. (bunq#133)
7ec1fb3
OGKevin added a commit to jorijn/sdk_php that referenced this issue Apr 9, 2018
@OGKevin
Removed plural from method name. (bunq#133)
92f1b04
OGKevin added a commit that referenced this issue Apr 9, 2018
@OGKevin
Merge pull request #136 from Jorijn/develop
34152ff 
Bunq-install should display error message and not installation util. (#133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorijn jorijn

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
1.0.0
2 participants
@jorijn @OGKevin