Skip to content

Commit

Permalink
Migrate <manifest package="..." in AndroidManifest.xml to namespace '…
Browse files Browse the repository at this point in the history
…...' in build.gradle.
  • Loading branch information
TWiStErRob authored and sjudd committed Aug 8, 2023
1 parent 49ddc01 commit 401d7e5
Show file tree
Hide file tree
Showing 60 changed files with 62 additions and 85 deletions.
1 change: 1 addition & 0 deletions annotation/compiler/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ afterEvaluate {
}

android {
namespace 'com.bumptech.glide.annotation.compiler.test'
compileSdk libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions annotation/compiler/test/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.annotation.compiler.test">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions annotation/ksp/integrationtest/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.annotation.ksp.integrationtest'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 1 addition & 4 deletions annotation/ksp/integrationtest/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.annotation.ksp.integrationtest">

</manifest>
<manifest />
1 change: 1 addition & 0 deletions annotation/ksp/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.annotation.ksp.test'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 1 addition & 4 deletions annotation/ksp/test/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.bumptech.glide.annotation.ksp.test">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions benchmark/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.benchmark'
compileSdkVersion libs.versions.compile.sdk.version.get()

buildToolsVersion "30.0.3"
Expand Down
3 changes: 1 addition & 2 deletions benchmark/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.bumptech.glide.benchmark">
xmlns:tools="http://schemas.android.com/tools">

<!--
Important: disable debugging for accurate performance results
Expand Down
3 changes: 1 addition & 2 deletions benchmark/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumptech.glide.benchmark">
</manifest>
<manifest />
2 changes: 1 addition & 1 deletion instrumentation/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.instrumentation'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
applicationId 'com.bumptech.glide.instrumentation'
minSdk libs.versions.min.sdk.version.get() as int
targetSdk libs.versions.target.sdk.version.get() as int
versionCode 1
Expand Down
4 changes: 2 additions & 2 deletions instrumentation/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.bumptech.glide.instrumentation">
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
<application
Expand Down
1 change: 1 addition & 0 deletions integration/avif/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.avif'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
3 changes: 1 addition & 2 deletions integration/avif/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.avif" />
<manifest />
1 change: 1 addition & 0 deletions integration/compose/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.integration.compose'
compileSdk 33

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions integration/compose/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.compose">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions integration/concurrent/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.concurrent'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions integration/concurrent/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest
package="com.bumptech.glide.integration.concurrent">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions integration/cronet/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.cronet'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 2 additions & 2 deletions integration/cronet/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.cronet">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
<meta-data
android:name="com.bumptech.glide.integration.cronet.CronetGlideModule"
Expand Down
3 changes: 1 addition & 2 deletions integration/cronet/src/test/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.cronet">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="26"/>
</manifest>
1 change: 1 addition & 0 deletions integration/gifencoder/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.gifencoder'
compileSdkVersion libs.versions.compile.sdk.version.get()

sourceSets {
Expand Down
4 changes: 1 addition & 3 deletions integration/gifencoder/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest
package="com.bumptech.glide.integration.gifencoder">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions integration/ktx/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.integration.ktx'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion integration/ktx/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumptech.glide.integration.ktx" />
<manifest />
1 change: 1 addition & 0 deletions integration/okhttp/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.okhttp'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions integration/okhttp/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest
package="com.bumptech.glide.integration.okhttp">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions integration/okhttp3/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.okhttp'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
3 changes: 1 addition & 2 deletions integration/okhttp3/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.okhttp">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
<meta-data
Expand Down
1 change: 1 addition & 0 deletions integration/okhttp4/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.okhttp'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions integration/okhttp4/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest
package="com.bumptech.glide.integration.okhttp">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions integration/recyclerview/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.recyclerview'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions integration/recyclerview/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest
package="com.bumptech.glide.integration.recyclerview">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions integration/sqljournaldiskcache/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.integration.sqljournaldiskcache'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions integration/sqljournaldiskcache/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.sqljournaldiskcache">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions integration/volley/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.volley'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
3 changes: 1 addition & 2 deletions integration/volley/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.volley">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
<meta-data
Expand Down
1 change: 1 addition & 0 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ if (project.plugins.hasPlugin('net.ltgt.errorprone')) {
}

android {
namespace 'com.bumptech.glide'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions library/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions library/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ android.testOptions.unitTests.all { Test testTask ->
}

android {
namespace 'com.bumptech.glide.test'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
3 changes: 1 addition & 2 deletions library/test/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumptech.glide.test">
</manifest>
<manifest />
1 change: 1 addition & 0 deletions mocks/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.mocks'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 1 addition & 3 deletions mocks/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.mocks">
</manifest>
<manifest />
2 changes: 1 addition & 1 deletion samples/contacturi/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.samples.contacturi'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
applicationId 'com.bumptech.glide.samples.contacturi'
minSdk libs.versions.min.sdk.version.get() as int
targetSdk libs.versions.target.sdk.version.get() as int

Expand Down
3 changes: 1 addition & 2 deletions samples/contacturi/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.samples.contacturi" >
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<uses-permission android:name="android.permission.READ_CONTACTS" />

Expand Down
2 changes: 1 addition & 1 deletion samples/flickr/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.samples.flickr'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
applicationId 'com.bumptech.glide.samples.flickr'
minSdk libs.versions.min.sdk.version.get() as int
targetSdk libs.versions.target.sdk.version.get() as int

Expand Down
3 changes: 1 addition & 2 deletions samples/flickr/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.bumptech.glide.samples.flickr">
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.INTERNET"/>
<!--
Expand Down
2 changes: 1 addition & 1 deletion samples/gallery/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ kotlin {
}

android {
namespace 'com.bumptech.glide.samples.gallery'
compileSdk 34

defaultConfig {
applicationId 'com.bumptech.glide.samples.gallery'
minSdk 29
targetSdk 34
versionCode 1
Expand Down
3 changes: 1 addition & 2 deletions samples/gallery/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.samples.gallery">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<uses-sdk
android:minSdkVersion="29"
Expand Down
2 changes: 1 addition & 1 deletion samples/giphy/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.samples.giphy'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
applicationId 'com.bumptech.glide.samples.giphy'
minSdk libs.versions.min.sdk.version.get() as int
targetSdk libs.versions.target.sdk.version.get() as int
versionCode 1
Expand Down
3 changes: 1 addition & 2 deletions samples/giphy/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.samples.giphy">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<uses-permission android:name="android.permission.INTERNET"/>
<!--
Expand Down
Loading

0 comments on commit 401d7e5

Please sign in to comment.