Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typeof to check presence of process instead of truthyness #15

Merged
merged 1 commit into from
May 17, 2019
Merged

Conversation

kyusu
Copy link
Contributor

@kyusu kyusu commented Mar 4, 2019

I recently had some issues with react-cookies in context of Storybook where my component keeps crashing because of a

ReferenceError: process is not defined

For some reason process in the context of my Storybook instance is not defined. While I will fix this of course, I thought I might make react-cookies a tad more robust by checking for the presence of process with typeof.

@kyusu
Copy link
Contributor Author

kyusu commented May 17, 2019

@bukinoshita Can you please merge this?

@bukinoshita bukinoshita merged commit c12841d into bukinoshita:master May 17, 2019
@bukinoshita
Copy link
Owner

Sorry for the delay! Merged and will push a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants