Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final prep #359

Merged
merged 1 commit into from
Nov 23, 2021
Merged

final prep #359

merged 1 commit into from
Nov 23, 2021

Conversation

thomassth
Copy link
Contributor

@thomassth thomassth commented Nov 22, 2021

Part of #346

  • Dry-run removed
  • Added changelogs to prereleases
  • removed pipeline to avoid potential clashes

Copy link
Contributor

@sowens-csd sowens-csd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was probably covered elsewhere and I missed it but I wanted to understand the outcome of the prerelease workflow before I approve.

I see that both prerelease and release have the dry_run: true option removed, so both are publishing to pub.dev. So the difference between the two versions is the addition of an explicit version number to the prerelease? In this section I think:

name: Edit pubspec.ymal for dev release
        run: |
          sed  -i "s/version.*/&-$GITHUB_RUN_ID/" pubspec.yaml

The current prerelease on pub.dev is 4.0.1-dev.13167 will this version keep the same version format? If so I'm not sure where the -dev. comes from. Also, on pub.dev currently the published dev version is explicitly listed as a prerelease but I'm not sure how the publish task does that?

@thomassth
Copy link
Contributor Author

According to this article, if there's anything attached to the end of version number, it is considered to be dev branch. The original pipeline also did it by attaching a build number.

Right now the github build number is longer than the one from azure, so I didn't put the dev- back in.

GITHUB_RUN_NUMBER is also avaliable, but it starts with 1 so it may clash with current prerelease. (perhaps we can use this at the next version bump.)

Copy link
Contributor

@sowens-csd sowens-csd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, makes sense.

@thomassth thomassth merged commit bf4371b into builttoroam:develop Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants