Housekeeping: Pipenv & Slimmer package #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR. It helps a lot to improve this module! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipenv is now the recommended official tool packaging Python project, the build script and documentation have been updated to reflect that.
Also the deployed zip contained several uneeded packages (such as
setuptoolsorwheel), now onlyrequestsand the lambda itself are packaged (zip size reduced by ~30%).The variable
slack_channel_mapwas previously a JSON encoded string which was forcing the user to manually escape sequence characters such as", instead we now use a map that we transform into a JSON compliant string withjsonencode.