More complete environment variable handling #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
jkutner
approved these changes
Jul 18, 2019
ekcasey
reviewed
Jul 24, 2019
buildpack.md
Outdated
|
|
||
| ##### Delimiter | ||
|
|
||
| If the environment variable file name ends in `.delim`, then the value of the environment variable MUST be used to delimit any concatenation within the same layer involving that environment variable. |
There was a problem hiding this comment.
The phrase "the value of the environment variable" feels a little weird here to me
How about:
"If an environment variable file name ends in .delim, the file contents MUST be used to delimit..."
nebhale
approved these changes
Jul 25, 2019
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
hone
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifecycle PR: buildpacks/lifecycle#147