Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize Platform 0.12 #371

Merged
merged 85 commits into from
Aug 3, 2023
Merged

Finalize Platform 0.12 #371

merged 85 commits into from
Aug 3, 2023

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Aug 1, 2023 •
edited
Loading

This release of the Cloud Native Buildpacks Specification defines Platform API 0.12.

Additions

Breaking Changes

  • The concepts of stacks and mixins are removed in favor of existing constructs in the container image ecosystem such as operating system name, operating system version, and architecture (Stack removal: platform changes #335, RFC 096).

Nonfunctional Changes

natalieparellano and others added 30 commits December 1, 2022 09:58
@natalieparellano
Removed stack and mixin from terminology, updated stack section
d38828a 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Update analyzer
a2d3554 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Format TOC, fix TODO
4531d8c 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Add derive missing values for known stack ID
58904f2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Add guidance around SBOM and rebase
3140c7d 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Fix nesting
f31e623 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Remove language about a "contract"
c58ae52 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Describe how analyzed is used by the detector
cac2d6e 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Remove other references to stack
d6141f2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename platform -> target
10293e9 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Small syntax change
ec8769e 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename architecture -> arch to match buildpack spec
0373ea9 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Wording
941516e 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename distro -> distribution and update schema of analyzed.toml to m…
b3c883b 
…atch buildpack spec

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
More rename platform -> target
64d392c 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Add run image extension to platform spec as per RFC 0105
156a812 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename stack.toml to run.toml and validate run image selection agains…
ef56944 
…t run.toml

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Apply suggestions from code review
796133a 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano @jkutner
Apply suggestions from code review
9828bf3 
Co-authored-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename stack.toml to run.toml and validate run image selection agains…
4480ba7 
…t run.toml

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename stack -> run
7c905e1 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Detector doesn't need run without run image extension
4de1087 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@pbusko @c0d1ngm0nk3y
Enhanced run image resolution
538e1d0 
Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>
Co-authored-by: Pavel Busko <pavel.busko@sap.com>
Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com>
@natalieparellano
Rename image -> images
905754e 
In lists we pluralize

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename image -> images
8a5929f 
In lists we pluralize

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano @hone
Update platform.md
7822f9a 
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Define base image and update TOC
9957239 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Init platform 0.12
1b0ea79 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Merge branch 'platform/0.12' into stack-removal/platform
c5d1691
@natalieparellano
Add back base image
381ee53 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano and others added 18 commits July 24, 2023 12:49
@natalieparellano
Merge branch 'stack-removal/platform' into run-image-extension/platform
b0ccf7c 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano @hone
Apply suggestions from code review
aec9203 
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Fix: platform-defined env vars are not actually overridable by buildp…
5feb0b5 
…acks

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Update platform.md
b4f9539 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Apply suggestions from code review
d6db122 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Update more label names
ea0bcde 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Update definition
4f4aa24 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Add further guidance about target ID
bc1e753 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Add -daemon to restorer
8581965 
This is needed when extensions were used to switch (but not extend) the run image
and we need to re-read the target data from the image config.

In such cases, we don't need the run image to exist in a registry,
because we don't need a manifest for kaniko.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Merge branch 'stack-removal/platform' into run-image-extension/platform
a133f82
@natalieparellano
Fix
134bdde 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Merge pull request #352 from jjbustamante/enhancement/issue-327-image…
9f8a0fb 
…-in-oci-layout-format

OCI layout spec changes
@natalieparellano
Merge branch 'platform/0.12' into stack-removal/platform
e7ac222
@natalieparellano
Merge branch 'stack-removal/platform' into run-image-extension/platform
ce7b1f8
@natalieparellano
Merge pull request #335 from buildpacks/stack-removal/platform
e6f047e 
Stack removal: platform changes
@natalieparellano
Merge pull request #347 from buildpacks/run-image-extension/platform
42c59ca 
Platform API changes for run image extension (Dockerfiles phase 3)
@natalieparellano
Merge branch 'platform/0.12' into fix/platform-vars
73cd163
@natalieparellano
Merge pull request #367 from buildpacks/fix/platform-vars
a65feb7 
Fix: platform vars
@natalieparellano natalieparellano requested a review from a team as a code owner August 1, 2023 17:02
hone
hone reviewed Aug 1, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
hone
hone approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@hone hone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, so I'm not blocking. I'm going to let @jabrown85 be my delegate approval vote.

natalieparellano
natalieparellano commented Aug 2, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Aug 2, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Apply suggestions from code review
3324444 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Remove target.id from the lifecycle
2d58de7 
Base images may still express this identifier as a label,
but it will not be used by the lifecycle nor provided to buildpacks.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Merge pull request #375 from buildpacks/remove-target-id-from-lifecycle
a641ca1 
Remove `target.id` from the lifecycle
@natalieparellano natalieparellano merged commit 7eb38d1 into main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hone hone hone approved these changes

@jabrown85 jabrown85 jabrown85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@natalieparellano @hone @jabrown85 @pbusko @modulo11 @jjbustamante @hernandanielg