-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #105 #185
Issue #105 #185
Conversation
@@ -8,6 +8,7 @@ set layers_dir=%1 | |||
echo [[processes]] >> %layers_dir%\launch.toml | |||
echo type = "web" >> %layers_dir%\launch.toml | |||
echo command = ["app.bat"] >> %layers_dir%\launch.toml | |||
default = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Srishti-j18 you need to write the value default = true
into the launch.toml
file, just follow the same way line 10 with the echo
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to do the equivalent for the bash buildpack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Srishti-j18,
Thanks a lot for the PR! you still need to do some changes to make it work! but it is ok
@@ -8,6 +8,7 @@ set layers_dir=%1 | |||
echo [[processes]] >> %layers_dir%\launch.toml | |||
echo type = "web" >> %layers_dir%\launch.toml | |||
echo command = ["app.bat"] >> %layers_dir%\launch.toml | |||
default = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to do the equivalent for the bash buildpack
Oh, my bad. I'll make changes according to your instructions. |
…buildpacks#105 Signed-off-by: Srishti-j18 <srishti33164jaiswal@gmail.com>
Signed-off-by: Srishti-j18 <srishti33164jaiswal@gmail.com>
Signed-off-by: Srishti-j18 <srishti33164jaiswal@gmail.com>
@@ -8,6 +8,7 @@ set layers_dir=%1 | |||
echo [[processes]] >> %layers_dir%\launch.toml | |||
echo type = "web" >> %layers_dir%\launch.toml | |||
echo command = ["app.bat"] >> %layers_dir%\launch.toml | |||
echo default = "true" >> %layers_dir%\launch.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the true
be quoted or unquoted here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry, It should be unquoted here, because, In TOML syntax, boolean values are represented without quotes to distinguish them from string values...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AidanDelaney ,I have corrected this typo..
Actually I corrected the format for Linux previously but forgot to update it for Windows.
Use the latest version of the buildpacks API Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net> Signed-off-by: Srishti-j18 <srishti33164jaiswal@gmail.com>
Using linux/amd64 allows linux builds on emulators (eg. macos M1/2/3). However it breaks Windows builds Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net> Signed-off-by: Srishti-j18 <srishti33164jaiswal@gmail.com>
Signed-off-by: Srishti-j18 <srishti33164jaiswal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thanks a lot for your attention to the detail.
fixed the issue dotnet sample app needs a default entrypoint .