Bump buildpack API version #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanDelaney
force-pushed
the
support-all-stacks
branch
8 times, most recently
from
d0ee5a0
to
a65a902
Compare
|
Moved the |
|
@AidanDelaney any interest in Rocky Linux builders? |
AidanDelaney
force-pushed
the
support-all-stacks
branch
2 times, most recently
from
dd7c59e
to
f5fb825
Compare
AidanDelaney
changed the title
AidanDelaney
force-pushed
the
support-all-stacks
branch
2 times, most recently
from
db89ee1
to
e6aa6be
Compare
AidanDelaney
force-pushed
the
support-all-stacks
branch
3 times, most recently
from
4ee5887
to
2bc2e73
Compare
Use a more recent Ubuntu LTS release Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Use a buildpack API version that is not subject to the deprecation RFC Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
These are both no-op buildpacks, make them syntactically the same. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
We build on Windows and Linux. Wine is a complexity that we do not need in order to demonstrate buildpacks. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Use the linux/amd64 base images on which to build our stacks. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
AidanDelaney
force-pushed
the
support-all-stacks
branch
from
2bc2e73
to
daa3048
Compare
We have removed the wine stack, now remove the builder. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Do not add the wine stack to buildpacks. Remove calls to build and deploy wine. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
jkutner
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the Ubuntu bionic stack to Ubuntu jammy. And support
a more recent buildpack API. Allow all sample buildpacks to be
used on all stacks.