Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Support Dockerfiles #173

Merged
merged 45 commits into from
Aug 10, 2022
Merged

RFC: Support Dockerfiles #173

merged 45 commits into from
Aug 10, 2022

Commits on Jun 30, 2021

  1. Add RFC: Support Dockerfiles 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    4f73fe4 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. RFC: Support Dockerfiles: remove stack references 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    ef2b230 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. RFC: Support Dockerfiles: add builder-specified Dockerfiles 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 15, 2021
    Configuration menu
    Copy the full SHA
    e21b2af View commit details
    Browse the repository at this point in the history

  2. RFC: Support Dockerfiles: Fix reference to app-specified Dockerfiles 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 15, 2021
    Configuration menu
    Copy the full SHA
    a1810ca View commit details
    Browse the repository at this point in the history

  3. RFC: Support Dockerfiles: Remove run.Dockerfile reference 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 15, 2021
    Configuration menu
    Copy the full SHA
    82cbe67 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. RFC: Support Dockerfiles: address more feedback 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 18, 2021
    Configuration menu
    Copy the full SHA
    a9daed9 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. RFC: Support Dockerfiles: fix typo 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Daniel Mikusa <dmikusa@vmware.com>
    @sclevine
    sclevine and Daniel Mikusa authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    3534dc2 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. RFC: Support Dockerfiles: Buildpack-associated hooks 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    05dc2d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. RFC: Support Dockerfiles: clarify builder vs. build-image 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Emily Casey <ecasey@vmware.com>
    @sclevine @ekcasey
    sclevine and ekcasey authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f3e84c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. RFC: Support Dockerfiles: integrate with buildpack API 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    1e813b9 View commit details
    Browse the repository at this point in the history

  2. RFC: Support Dockerfiles: Add build args + runtime SBoM 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    ba9ebd7 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Fix buildpack dir env var 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
    @sclevine @natalieparellano
    sclevine and natalieparellano authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    58ed531 View commit details
    Browse the repository at this point in the history

  2. Clarify detect logic 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
    @sclevine @natalieparellano
    sclevine and natalieparellano authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    ebf6b2a View commit details
    Browse the repository at this point in the history

  3. Fix typo 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Javier Romero <rjavier@vmware.com>
    @sclevine @jromero
    sclevine and jromero authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    22f0ef4 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Use UUID for build_id 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
    @sclevine @natalieparellano
    sclevine and natalieparellano authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    084822e View commit details
    Browse the repository at this point in the history

  2. Fix wording re: rebasable label 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
    @sclevine @natalieparellano
    sclevine and natalieparellano authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    b3b38ea View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Clarify phases 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
    @sclevine @natalieparellano
    sclevine and natalieparellano authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    6eed4b2 View commit details
    Browse the repository at this point in the history

  2. RFC: Support Dockerfiles: clarify UID/GID of executables 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    fde7b84 View commit details
    Browse the repository at this point in the history

  3. RFC: Support Dockerfiles: rename hook to extension 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f643f8b View commit details
    Browse the repository at this point in the history

  4. RFC: Support Dockerfiles: fix typo 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    3a37d54 View commit details
    Browse the repository at this point in the history

  5. RFC: Support Dockerfiles: remove static provides 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f513c24 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Clarify Dockerfile restrictions 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
    @sclevine @natalieparellano
    sclevine and natalieparellano authored Feb 16, 2022
    Configuration menu
    Copy the full SHA
    884eaef View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Move extensions out of order table 

    Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
    @sclevine @natalieparellano
    sclevine and natalieparellano authored Mar 1, 2022
    Configuration menu
    Copy the full SHA
    cd9471f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    a2c06a5 View commit details
    Browse the repository at this point in the history

  2. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2935c8a View commit details
    Browse the repository at this point in the history

  3. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    01786f8 View commit details
    Browse the repository at this point in the history

  4. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    10a02f2 View commit details
    Browse the repository at this point in the history

  5. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2c7bb58 View commit details
    Browse the repository at this point in the history

  6. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2c6ca72 View commit details
    Browse the repository at this point in the history

  7. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    aa74ace View commit details
    Browse the repository at this point in the history

  8. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    10b6c9f View commit details
    Browse the repository at this point in the history

  9. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    1cc2789 View commit details
    Browse the repository at this point in the history

  10. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    a2282f1 View commit details
    Browse the repository at this point in the history

  11. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9ba0bc2 View commit details
    Browse the repository at this point in the history

  12. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9533642 View commit details
    Browse the repository at this point in the history

  13. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    bfc5781 View commit details
    Browse the repository at this point in the history

  14. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    68773ac View commit details
    Browse the repository at this point in the history

  15. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    fefd338 View commit details
    Browse the repository at this point in the history

  16. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    74767a0 View commit details
    Browse the repository at this point in the history

  17. Update text/0000-dockerfiles.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
    @sclevine
    sclevine authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    3b73177 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Add a note about resolving registry credentials up front 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    4abb253 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Updates per Emily's feedback 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    f8e7bfa View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Updates per 7/7/22 Working Group 

    - Change launch.toml -> run.toml since there are no overlapping fields between buildpacks and extensions
- Remove Dockerfile without a prefix since the args must be specified in either build.toml or run.toml
- Change must -> should for defaulting build_id
- Nest pre-populated output files under detect or generate (future proofing)
- Mention how we'll preserve top layer information for rebase

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3a26570 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Emily Casey <ecasey@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    73de183 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Updates per 7/14 Working Group 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    9325a13 View commit details
    Browse the repository at this point in the history