Streamline test setup #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optional PR, checking to see what folks think. This PR reduces the boilerplate code with test setup. It uses Go test's `TempDir` method to make temp directories. These are automatically cleaned up, so we don't have to deal with defer and clean up methods. The PR also stores the test object, so it's not necessary to pass around via method arguments. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:task
sambhav
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional PR, checking to see what folks think.
This PR reduces the boilerplate code with test setup. It uses Go test's
TempDirmethod to make temp directories. These are automatically cleaned up, so we don't have to deal with defer and clean up methods. The PR also stores the test object, so it's not necessary to pass around via method arguments.Signed-off-by: Daniel Mikusa dmikusa@vmware.com