-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stack subcommand in place of suggest-stacks #937
Conversation
Signed-off-by: anshlykov <andrew.shlykov@ya.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help! Looks great, but I left a few nits to take care of.
Signed-off-by: anshlykov <andrew.shlykov@ya.ru>
@dfreilich thanks for the feedback! fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks for the help @anshlykov !
UA
|
Based on the initial proposal (RFC), it would be the former, as implemented. It may not read well, in English terms, but its intent is to "group" based on resources. Open to more conversation via slack or other means.
I think that's a bit misleading. Don't know the exact wording we should use but maybe something like: "Commands available to stacks"? As it stands, I think it's mergeable though. |
Summary
Based on RFC #58 and #919, I hid the old
suggest-stacks
command and added thestack
subcommand.Documentation
Related
Resolves #919