Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack subcommand in place of suggest-stacks #937

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

anshlykov
Copy link
Contributor

Summary

Based on RFC #58 and #919, I hid the old suggest-stacks command and added the stack subcommand.

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #919

@anshlykov anshlykov requested a review from a team as a code owner November 5, 2020 15:00
Signed-off-by: anshlykov <andrew.shlykov@ya.ru>
@dfreilich dfreilich changed the title pack stack subcommand Add stack subcommand in place of suggest-stacks Nov 6, 2020
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! Looks great, but I left a few nits to take care of.

internal/commands/stack/suggest.go Outdated Show resolved Hide resolved
internal/commands/stack/suggest_test.go Outdated Show resolved Hide resolved
internal/commands/stack/suggest_test.go Outdated Show resolved Hide resolved
internal/commands/stack/suggest_test.go Outdated Show resolved Hide resolved
internal/commands/suggest_stacks_test.go Outdated Show resolved Hide resolved
Signed-off-by: anshlykov <andrew.shlykov@ya.ru>
@anshlykov
Copy link
Contributor Author

@dfreilich thanks for the feedback! fixed

Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks for the help @anshlykov !

super

@dfreilich
Copy link
Member

UA

pack help

image

pack help stack

image

pack stack suggest

image

pack suggest-stacks

image

@jromero Do you think it should be pack stack suggest, or pack suggests stack? Also, what do you think about the pack stack help test: Displays stack information?

@jromero
Copy link
Member

jromero commented Nov 9, 2020

@dfreilich:

Do you think it should be pack stack suggest, or pack suggests stack?

Based on the initial proposal (RFC), it would be the former, as implemented. It may not read well, in English terms, but its intent is to "group" based on resources. Open to more conversation via slack or other means.

Also, what do you think about the pack stack help te[x]t: "Displays stack information?"

I think that's a bit misleading. Don't know the exact wording we should use but maybe something like: "Commands available to stacks"? As it stands, I think it's mergeable though.

@jromero jromero merged commit 845080e into buildpacks:main Nov 9, 2020
@jromero jromero added this to the 0.16.0 milestone Nov 11, 2020
@jromero jromero added the type/enhancement Issue that requests a new feature or improvement. label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pack stack subcommand
3 participants