-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pack set-default-registry
command
#876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jromero
suggested changes
Oct 5, 2020
elbandito
force-pushed
the
set_registry
branch
from
October 6, 2020 23:43
526038f
to
885c888
Compare
elbandito
force-pushed
the
set_registry
branch
from
October 6, 2020 23:48
885c888
to
3be55f1
Compare
Signed-off-by: Travis <longoria.public@gmail.com>
elbandito
force-pushed
the
set_registry
branch
from
October 7, 2020 14:45
3be55f1
to
e6fd50c
Compare
dfreilich
previously requested changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor nits, but overall looks great!
One more nit: can we move the |
Signed-off-by: Travis <longoria.public@gmail.com>
elbandito
force-pushed
the
set_registry
branch
from
October 20, 2020 15:13
5226b22
to
2d6765b
Compare
Signed-off-by: Travis <longoria.public@gmail.com>
@jromero and @dfreilich I made changes per comments. Can I get a final look and blessing? |
jromero
changed the title
feat: pack set-default-registry
Add Oct 20, 2020
pack set-default-registry
command
jromero
added
type/enhancement
Issue that requests a new feature or improvement.
experimental
Issue or PR refers to an experimental feature.
labels
Oct 20, 2020
jromero
approved these changes
Oct 20, 2020
Signed-off-by: Javier Romero <rjavier@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
experimental
Issue or PR refers to an experimental feature.
type/enhancement
Issue that requests a new feature or improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Travis longoria.public@gmail.com
Summary
This PR introduces a new
pack
command to allow the user to set the default registry name viapack set-registry
.Output
New
Documentation
Related
Resolves #745