Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pack set-default-registry command #876

Merged
merged 6 commits into from
Oct 20, 2020
Merged

Add pack set-default-registry command #876

merged 6 commits into from
Oct 20, 2020

Conversation

elbandito
Copy link
Member

@elbandito elbandito commented Oct 5, 2020

Signed-off-by: Travis longoria.public@gmail.com

Summary

This PR introduces a new pack command to allow the user to set the default registry name via pack set-registry.

Output

New

❯ pack
CLI for building apps using Cloud Native Buildpacks

Usage:
  pack [command]

Available Commands:
  set-default-registry              Set default registry
❯ pack set-default-registry --help
Set default registry

Usage:
  pack set-default-registry <name> [flags]

Examples:
pack set-default-registry myregistry

Flags:
  -h, --help   Help for 'set-registry'

Global Flags:
      --no-color     Disable color output
  -q, --quiet        Show less output
      --timestamps   Enable timestamps in output
  -v, --verbose      Show more output

Documentation

  • Should this change be documented?
    • [ X ] Yes, see #___
    • No

Related

Resolves #745

@elbandito elbandito requested a review from a team as a code owner October 5, 2020 20:06
@elbandito elbandito requested a review from jromero October 5, 2020 20:20
internal/commands/set_registry.go Outdated Show resolved Hide resolved
internal/commands/set_registry.go Outdated Show resolved Hide resolved
@jromero jromero mentioned this pull request Oct 5, 2020
1 task
@elbandito elbandito changed the title feat: pack set-registry feat: pack set-default-registry Oct 6, 2020
Signed-off-by: Travis <longoria.public@gmail.com>
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor nits, but overall looks great!

internal/commands/set_default_registry_test.go Outdated Show resolved Hide resolved
internal/commands/set_default_registry_test.go Outdated Show resolved Hide resolved
@dfreilich
Copy link
Member

One more nit: can we move the cmd.Example to be part of the definition of the cmd?

Signed-off-by: Travis <longoria.public@gmail.com>
Signed-off-by: Travis <longoria.public@gmail.com>
@elbandito elbandito requested a review from dfreilich October 20, 2020 15:34
@elbandito
Copy link
Member Author

@jromero and @dfreilich I made changes per comments. Can I get a final look and blessing?

@jromero jromero changed the title feat: pack set-default-registry Add pack set-default-registry command Oct 20, 2020
@jromero jromero added type/enhancement Issue that requests a new feature or improvement. experimental Issue or PR refers to an experimental feature. labels Oct 20, 2020
@jromero jromero added this to the 0.15.0 milestone Oct 20, 2020
Signed-off-by: Javier Romero <rjavier@vmware.com>
@jromero jromero merged commit 30363df into main Oct 20, 2020
@jromero jromero deleted the set_registry branch October 20, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Issue or PR refers to an experimental feature. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildpack Registry config commands
3 participants