Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump default lifecycle version #473

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Bump default lifecycle version #473

merged 1 commit into from
Jan 27, 2020

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Jan 27, 2020 •
edited by zmackie
Loading

Also bump default platform api version since lifecycle 0.6.0 implements
a newer api.

Closes: #465

@natalieparellano natalieparellano requested a review from a team as a code owner January 27, 2020 17:19
jromero
jromero suggested changes Jan 27, 2020
View reviewed changes
Copy link
Member

@jromero jromero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested. Also, seems like DCO is not happy.

internal/builder/lifecycle.go Outdated Show resolved Hide resolved
@zmackie
Copy link
Contributor

zmackie commented Jan 27, 2020

@natalieparellano DCO too

@natalieparellano
Bump default lifecycle version
1aca8c1 
- Also bump default platform api version since lifecycle 0.6.0 implements
  a newer api.
- Move const and make private - it is only used in acceptance tests.

Signed-off-by: Natalie Arellano <narellano@pivotal.io>
@natalieparellano natalieparellano force-pushed the feature/465-bump-default-lifecycle branch from af1e4fd to 1aca8c1 Compare January 27, 2020 19:21
@zmackie zmackie requested a review from jromero January 27, 2020 19:22
@zmackie zmackie added status/code-approved Pull Request code has been approved. status/user-accepted Pull Request that has passed user acceptance. and removed status/code-approved Pull Request code has been approved. labels Jan 27, 2020
@zmackie
Copy link
Contributor

zmackie commented Jan 27, 2020

Accepted with:

± zm |feature/465-bump-default-lifecycle ✓| → ./out/pack create-builder cnb/test:427 -b ../samples/builders/alpine/builder.toml
alpine: Pulling from cnbs/sample-stack-build
89d9c30c1d48: Pull complete
302925c3e5ee: Pull complete
cb671823678c: Pull complete
1c6cc53beebd: Pull complete
09fd1c2de20b: Pull complete
Digest: sha256:b67ea4429326f5322a8ad94f2a297bd80abe3310a39d5451b9434dc3d28aeb79
Status: Downloaded newer image for cnbs/sample-stack-build:alpine
Downloading from https://github.com/buildpacks/lifecycle/releases/download/v0.6.0/lifecycle-v0.6.0+linux.x86-64.tgz
25.6 MB/25.6 MB
Successfully created builder image cnb/test:427
Tip: Run pack build <image-name> --builder cnb/test:427 to use this builder

  |2.6.3| NY-Floater-15565 in ~/workspace/pack
± zm |feature/465-bump-default-lifecycle ✓| → ./out/pack inspect-builder cnb/test:427
Inspecting builder: cnb/test:427

REMOTE:
(not present)

LOCAL:

Created By:
  Name: Pack CLI
  Version: dev-2020-01-27-14:42:13

Stack:
  ID: io.buildpacks.samples.stacks.alpine

Lifecycle:
  Version: 0.6.0
  Buildpack API: 0.2
  Platform API: 0.2

Run Images:
  cnbs/sample-stack-run:alpine

Buildpacks:
  ID                                         VERSION
  io.buildpacks.samples.java-maven           0.0.1
  io.buildpacks.samples.kotlin-gradle        0.0.1

Detection Order:
  Group #1:
    io.buildpacks.samples.java-maven@0.0.1
  Group #2:
    io.buildpacks.samples.kotlin-gradle@0.0.1


± zm |feature/465-bump-default-lifecycle ✓| → ./out/pack report
Pack:
  Version:  dev-2020-01-27-14:42:13
  OS/Arch:  darwin/amd64

Default Lifecycle Version:  0.6.0

Config:
  default-builder-image = "cloudfoundry/cnb:bionic"

@zmackie zmackie merged commit cb5985e into master Jan 27, 2020
@dfreilich dfreilich deleted the feature/465-bump-default-lifecycle branch November 6, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero approved these changes

Assignees
No one assigned
Labels
status/user-accepted Pull Request that has passed user acceptance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump DefaultLifecycle to 0.6.0
3 participants
@natalieparellano @zmackie @jromero