Fix create-builder with multiple buildpacks of same id #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove comptability layer (except for lifecycle symlink) - Remove comptability metadata from builder creation - Introduce COMPILE_PACK_WITH_VERSION env variable for running acceptance tests - Add pack_previous_fixtures_overrides directory to enable overriding fixtures used for previous pack versions Signed-off-by: Andrew Meyer <ameyer@pivotal.io> Signed-off-by: Natalie Arellano <narellano@pivotal.io>
natalieparellano
force-pushed
the
fix/430-dedup-buildpacks
branch
from
44eedd5 to
cb76022
Compare
jromero
reviewed
Jan 17, 2020
acceptance/acceptance_test.go
Outdated
| defer os.RemoveAll(tmpPreviousPackFixturesPath) | ||
|
|
||
| h.RecursiveCopy(t, previousPackFixturesPath, tmpPreviousPackFixturesPath) | ||
| h.RecursiveCopy(t, filepath.Join("testdata", "pack_previous_fixtures_overrides"), tmpPreviousPackFixturesPath) |
There was a problem hiding this comment.
I think I understand why this is needed. Maybe it's worth creating a README.md in that directory that entails exactly why you would put stuff in that directory.
Also, would it not suffer from the same problems we originally had with "pack_previous" in which you had to update the repo after a release because "current" was (de)moted to "previous"?
There was a problem hiding this comment.
Would vote on punting on the docs so we can get this out. Thoughts @jromero?
It won't suffer from the same problems if it just has the version-related files like it has now. But true, it could suffer in general. Hopefully these are the only type of files we'd need. We'll keep an eye on this.
- Remove compat unit tests that are no longer needed - Only add the compat layer path to the layers for an image if the compat.tar exists - `make acceptance` should only require previous pack fixtures to be a valid directory if the env variable is set Signed-off-by: Natalie Arellano <narellano@pivotal.io> Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
- Place lifecycle symlink in lifecycle layer since it is all that is left of the compat logic Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
jromero
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #430
for previous pack versions
Signed-off-by: Natalie Arellano narellano@pivotal.io
Signed-off-by: Andrew Meyer ameyer@pivotal.io