fixes #381 #395
Closed
fixes #381 #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: Other implementations satisfy the purpose of the fake logger. It's thereby simply more code to maintain without added value Signed-off-by: Javier Romero <jromero@pivotal.io>
Signed-off-by: Javier Romero <jromero@pivotal.io>
Signed-off-by: ktpv <ktpv@users.noreply.github.com>
…logger Remove fake logger
Add more badges to README.md
Signed-off-by: ktpv <ktpv@users.noreply.github.com>
jromero
suggested changes
Dec 4, 2019
There was a problem hiding this comment.
Hi 👋, thanks for the contribution!
There are two lingering issues with this PR which prevent us from merging it:
- The tests are not passing on travis.
- The diff appears to show duplicate commits. Looking at the commit tree confirms the duplication.
* 2019-12-03 36576af - (HEAD -> ktpv-i381) Merge branch 'i381' of https://github.com/ktpv/pack into i381 [ktpv] N
|\
| * 2019-11-24 b93fdab - fixes #381 [ktpv] N
* | 2019-11-24 d77e904 - fixes #381 [ktpv] N
* | 2019-12-01 789347b - (origin/master, origin/HEAD) Merge pull request #391 from buildpack/feature/moar-badges [GitHub] E
You might find some information available in our CONTRIBUTING.md helpful.
|
Redid in PR #404. Closing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ktpv ktpv@users.noreply.github.com