Adds basic compatibility with buildpack/lifecycle#149 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkutner
reviewed
Aug 5, 2019
acceptance/testdata/mock_buildpacks/v1/simple-layers-buildpack/buildpack.toml
Outdated
Show resolved
Hide resolved
jkutner
reviewed
Aug 5, 2019
ameyer-pivotal
force-pushed
the
feature/243-basic-compat
branch
6 times, most recently
from
c0e9bc4 to
5cbd7bc
Compare
ekcasey
requested changes
Aug 9, 2019
There was a problem hiding this comment.
Overall looks very good, I have just a couple things.
- The many small data types in
builderconfuse me. Several of them are exactly the same. - We should add an order buildpack (?, metabuildpack buildpack? whatever we are calling them?) to the acceptance test, but I am happy to accept that as a follow on PR
- We don't seem to be unit testing all the
latestcases, e.g the cases wherelatestisfalsein the metadata
ekcasey
force-pushed
the
feature/243-basic-compat
branch
from
9761daf to
1deff20
Compare
Resolves #243 Signed-off-by: Andrew Meyer <ameyer@pivotal.io> Signed-off-by: Javier Romero <jromero@pivotal.io>
ekcasey
force-pushed
the
feature/243-basic-compat
branch
from
1deff20 to
b64c4fb
Compare
…adlock) Signed-off-by: Javier Romero <jromero@pivotal.io> Signed-off-by: Emily Casey <ecasey@pivotal.io>
ekcasey
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #243
Relates to buildpacks/lifecycle#149
Signed-off-by: Andrew Meyer ameyer@pivotal.io
Signed-off-by: Javier Romero jromero@pivotal.io