Store download cache in versioned directories #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jromero
commented
Jul 5, 2019
| h.AssertMatch(t, out, `\.tgz$`) | ||
| h.AssertOnTarEntry(t, out, "file.txt", h.ContentEquals("some file contents")) | ||
| }) | ||
| it("caches to versioned directory", func() { |
There was a problem hiding this comment.
This is the only added test. All other changes here are just clean up/organizational.
jromero
force-pushed
the
issue/229-download-cache
branch
2 times, most recently
from
9232c9e to
18f4dd3
Compare
Signed-off-by: Javier Romero <jromero@pivotal.io>
jromero
force-pushed
the
issue/229-download-cache
branch
from
18f4dd3 to
64618b4
Compare
ekcasey
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #229
Signed-off-by: Javier Romero jromero@pivotal.io