Support pack build --platform
#2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/enhancement
Fixes #2154 Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
build-with-platform
branch
from
26aad31 to
d81ec16
Compare
pkg/image/fetcher.go
Outdated
| // Sample error from docker engine: | ||
| // `image with reference <image> was found but does not match the specified platform: wanted linux/amd64, actual: linux` | ||
| if strings.Contains(err.Error(), "does not match the specified platform") && | ||
| strings.HasSuffix(strings.TrimSpace(err.Error()), "actual: linux") { |
There was a problem hiding this comment.
I added this to make the acceptance test work, but I think it's actually closer to what we want anyway
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2162 +/- ##
==========================================
+ Coverage 70.15% 70.18% +0.03%
==========================================
Files 253 253
Lines 18412 18449 +37
==========================================
+ Hits 12916 12947 +31
- Misses 4650 4656 +6
Partials 846 846
Flags with carried forward coverage won't be shown. Click here to find out more. |
natalieparellano
force-pushed
the
build-with-platform
branch
from
5779431 to
f2cd826
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
LCOW appears to fallback to the arch it can find Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
This looks good to me, the only thing is adding back |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jjbustamante
approved these changes
May 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2154
Has a merge conflict with #2086 - let's get that one in first and then update this one