Warn misconfiguration keys in project.toml only for tables we own #2155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With pack PR 2042 we added a warning message when unsupported keys are declared in
project.toml
, the problem was that our spec allow the end-users to extend the file outside allnon-_
table and this shouldn't print a warningOutput
Before
Any
project.toml
version 0.1 or 0.2 with something like declaredWill print a warning message
After
We will only print a warning message for keys under
_.*
that are not supported or ifbuildpack.io
is being used and not valid, everything else will be ignoreDocumentation
Related
Resolves #1922