Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated GHA ::set-output syntax #1677

Merged

Conversation

phil9909
Copy link
Contributor

Summary

Use the new way of producing outputs in a github action as the old way is deprecated and will be removed (31st May 2023).

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

It was already partially done in #1564, but:

  • The PR missed some occurrences (or maybe they were introduced later).
  • Multi-line handling was not properly migrated from the old style to the new style in .github/workflows/build.yml, which causes the release notes of e.g. v0.28.0 to look odd (after "You should see the following output")

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

@phil9909 phil9909 requested review from a team as code owners March 17, 2023 15:56
@github-actions github-actions bot added this to the 0.29.0 milestone Mar 17, 2023
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Mar 17, 2023
@phil9909 phil9909 force-pushed the replace-deprecated-gha-syntax branch from 184a22e to 235bd0a Compare March 17, 2023 15:56
@jjbustamante
Copy link
Member

@phil9909, could you point us to how to deal with multi-lines?

Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks, @phil9909 for this PR!!! ❤️

@dfreilich dfreilich modified the milestones: 0.29.0, 0.30.0 Mar 26, 2023
@jkutner jkutner enabled auto-merge March 28, 2023 22:26
@jkutner
Copy link
Member

jkutner commented Mar 28, 2023

@phil9909 thanks! if you get a chance to update your branch please do. otherwise I'll pull this into my own PR tomorrow.

@phil9909 phil9909 force-pushed the replace-deprecated-gha-syntax branch from 235bd0a to 3b48c56 Compare March 29, 2023 05:45
Signed-off-by: Philipp Stehle <philipp.stehle@sap.com>
auto-merge was automatically disabled March 29, 2023 06:25

Head branch was pushed to by a user without write access

@phil9909 phil9909 force-pushed the replace-deprecated-gha-syntax branch from 3b48c56 to 5e73262 Compare March 29, 2023 06:25
@phil9909
Copy link
Contributor Author

Auto merge was auto disabled, @jkutner could you merge this manually?

@jkutner jkutner merged commit 18662b2 into buildpacks:main Mar 29, 2023
@jkutner
Copy link
Member

jkutner commented Mar 29, 2023

@phil9909 thanks!

@phil9909 phil9909 deleted the replace-deprecated-gha-syntax branch March 30, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants