Resolve symbolic links for app dir #165
Conversation
|
@jromero Apologies, we basically did a wholesale rewrite of build as part of our effort to move all the major commands onto the |
Signed-off-by: Javier Romero <j.romero.1214@gmail.com>
build_test.go
Outdated
| relLink := filepath.Join("testdata", "some-app.link") | ||
|
|
||
| _ = os.Remove(relLink) | ||
| h.AssertNil(t, os.Symlink(relLinkRef, relLink)) |
There was a problem hiding this comment.
If we are going to make temporary file for testing we should make them in a temp dir instead of in the repo. We generally only use the testdata dir if we are going to commit the files.
There was a problem hiding this comment.
Full disclosure: I did feel a tad dirty doing it this way.
I initially attempted to follow the prior practice of using fixtures but when it came time to submit the PR I remembered that git doesn't play nice with symlinks. I obviously should have choose a different path. Thanks for the redirection. Hope it's better now.
Signed-off-by: Javier Romero <j.romero.1214@gmail.com>
|
@jromero thanks for the contribution! |
Resolves #93
Signed-off-by: Javier Romero j.romero.1214@gmail.com