if lifecycle image is supplied, consider its apis #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
joe-kimmel-vmw
force-pushed
the
lifecyle-api-versions-check
branch
2 times, most recently
from
aa80e11 to
7d6fbeb
Compare
if we're injecting a custom lifecycle image into an untrusted builder, when we select the platform api version we'll consider the intersection between the builder, the lifecycle, and this instance of pack when choosing which version of the api to speak. because this is a rare case, the default is that there is no lifecycle api list, which is treated as no constraints. Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
force-pushed
the
lifecyle-api-versions-check
branch
from
7d6fbeb to
cef80f6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
- Coverage 80.59% 79.61% -0.97%
==========================================
Files 156 156
Lines 10489 10544 +55
==========================================
- Hits 8453 8394 -59
- Misses 1534 1644 +110
- Partials 502 506 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
natalieparellano
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Looks great, amazing work @joe-kimmel-vmw! Thank you for the contribution 😸
jkutner
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if we're injecting a custom lifecycle image into an untrusted builder, when we select the platform api version we'll consider the intersection between the builder, the lifecycle, and this instance of pack when choosing which version of the api to speak.
because this is a rare case, the default is that there is no lifecycle api list, which is treated as no constraints.
Output
Before
technically you could've used a lifecycle that didn't support the highest common version supported by both pack and the builder, but in practice i think this never happened.
After
Now it really can't ever happen.
Documentation
Related
Resolves #1091