Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pack extension --help #1603

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Conversation

itsdarshankumar
Copy link
Contributor

Summary

Added command to show output for "pack extension --help"

Output

image

image

Before

No such command exists before
image

Related

Resolves #1470

@itsdarshankumar itsdarshankumar requested review from a team as code owners January 20, 2023 23:40
@github-actions github-actions bot added this to the 0.29.0 milestone Jan 20, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #1603 (f6d7a9c) into main (05c18f3) will decrease coverage by 1.05%.
The diff coverage is 69.39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
- Coverage   80.62%   79.56%   -1.05%     
==========================================
  Files         156      163       +7     
  Lines       10563    10661      +98     
==========================================
- Hits         8515     8481      -34     
- Misses       1542     1668     +126     
- Partials      506      512       +6     
Flag Coverage Δ
os_linux 79.34% <69.39%> (-0.09%) ⬇️
os_macos 77.39% <69.39%> (-0.10%) ⬇️
os_windows 79.47% <69.39%> (-1.05%) ⬇️
unit 79.56% <69.39%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natalieparellano natalieparellano linked an issue Jan 23, 2023 that may be closed by this pull request
@natalieparellano
Copy link
Member

Apologies @itsdarshankumar, I may be confused - is this PR intended to resolve #1606, or just the --help aspect of pack extension? I think either approach is fine but just want to make sure we've linked to the right issue :)

@itsdarshankumar
Copy link
Contributor Author

Apologies @itsdarshankumar, I may be confused - is this PR intended to resolve #1606, or just the --help aspect of pack extension? I think either approach is fine but just want to make sure we've linked to the right issue :)

@natalieparellano This PR is for --help, I'll add another PR for #1606

Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ok to be merged, Darshan is also working in the implementation of each of the commands for extension on pack, and this one is required.

CC @samj1912 , @hone , @dfreilich , @jkutner

@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. and removed type/chore Issue that requests non-user facing changes. labels Feb 2, 2023
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. and removed type/chore Issue that requests non-user facing changes. labels Feb 2, 2023
@itsdarshankumar itsdarshankumar force-pushed the extensions branch 2 times, most recently from 9c9e4d7 to d794c90 Compare February 2, 2023 02:50
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. and removed type/chore Issue that requests non-user facing changes. labels Feb 2, 2023
@itsdarshankumar itsdarshankumar force-pushed the extensions branch 2 times, most recently from cd8fedd to 029026d Compare February 2, 2023 12:12
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
@natalieparellano
Copy link
Member

@buildpacks/toc any thoughts on this one?

@jkutner jkutner merged commit 21d769e into buildpacks:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pack should support pack extension * commands
4 participants